Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethyca/fidesplus/issues/368
Turns out this was pretty easy, thanks to some built in RTK polling functionality 🎉
Code Changes
useGetAllClassifyInstancesQuery
which stops once all classifications are done. I set it to 20 seconds, though it's easy to change if we want.I couldn't think of a good way to cypress test this one since it depends on waiting quite a while for the next poll to happen.
Steps to Confirm
/add-systems
flow and use the data flow scanner. Continue until you end up at the classifications page, which should show all entries as "Processing"/api/v1/plus/classify
Awaiting Review
. At this point, you should no longer see requeries for/api/v1/plus/classify
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats